----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30583/#review71695 -----------------------------------------------------------
src/slave/containerizer/containerizer.cpp <https://reviews.apache.org/r/30583/#comment117561> Specify you are using the default value and log the value? src/tests/containerizer.hpp <https://reviews.apache.org/r/30583/#comment117562> To be safe never create slave flags without using CreateSlaveFlags(). I would recommend taking the 2nd argument as Option with default to None, much like we did in MesosTest. src/tests/containerizer.cpp <https://reviews.apache.org/r/30583/#comment117563> Once you make this Option, do flags.isNone() ? CreateSlaveFlags() : flags.get() src/tests/mesos.cpp <https://reviews.apache.org/r/30583/#comment117564> you can just do new TestContainerizer(executor, flags) once you make the above suggested change. src/tests/mesos.cpp <https://reviews.apache.org/r/30583/#comment117565> ditto. - Vinod Kone On Feb. 4, 2015, 10:43 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30583/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 10:43 p.m.) > > > Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2228 > https://issues.apache.org/jira/browse/MESOS-2228 > > > Repository: mesos > > > Description > ------- > > Now the `"MESOS_RECOVERY_TIMEOUT"` environment variable is set based on the > flag value, instead of the `EXECUTOR_SHUTDOWN_GRACE_PERIOD` constant. > > It also now correctly uses `Duration::create` to interpret the protobuf value. > > > Diffs > ----- > > src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443 > src/launcher/executor.cpp 1cf28f168cac6e8c7e98686a35509c2b4e052504 > src/slave/containerizer/containerizer.hpp > 129e60f20835f5d151701e934330b81825887af1 > src/slave/containerizer/containerizer.cpp > 421bb868b353e644578fa27f04bdd636bfc89134 > src/slave/containerizer/docker.hpp b7bf54ac65d6c61622e485ac253513eaac2e4f88 > src/slave/containerizer/docker.cpp 5f4b4ce49a9523e4743e5c79da4050e6f9e29ed7 > src/slave/containerizer/external_containerizer.cpp > 8d5a9047afb24a29413bfc7226f47b1edbfa4ff9 > src/slave/containerizer/mesos/containerizer.cpp > d712278428889ebdfd598537690138329d8464f0 > src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 > src/tests/containerizer.cpp 26b87ac6b16dfeaf84888e80296ef540697bd775 > src/tests/gc_tests.cpp 454f0974833ad5db8b504a36b010cc72c3a19751 > src/tests/hook_tests.cpp 44f73effdce2d03627215418007ccbc3263a0c52 > src/tests/master_allocator_tests.cpp > 018a6ccba8bb78974de06398f423f1f30ef3a3df > src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed > src/tests/mesos.cpp 5ed4df530cf1bf11eec3b29542641822e0f702b2 > src/tests/slave_recovery_tests.cpp 7e2e63d4b8a1cd7c191374bc37073d83ae413e03 > src/tests/slave_tests.cpp e7e2af63da785644f3f7e6e23607c02be962a2c6 > > Diff: https://reviews.apache.org/r/30583/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
