----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30510/#review71826 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment117685> Hmm. We should fix the update semantics in the slave. Looks like we do the right thing when updating resources after a terminal update but don't wait for update to continue when sending run task messages. Isn't this a problem with persistent volume if a task is launched on the executor but a persistent volume is not available for the container? src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment117683> s/is that/are that/ src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment117687> Log a warning here? src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/30510/#comment117688> Log a warning here? - Vinod Kone On Feb. 10, 2015, 1:13 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30510/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 1:13 a.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, Michael Park, and Vinod > Kone. > > > Bugs: MESOS-2031 > https://issues.apache.org/jira/browse/MESOS-2031 > > > Repository: mesos > > > Description > ------- > > Allowed Mesos containerizer to prepare and update volumes. > > Mesos containerizer setup volumes for the container. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > b3aafe4efa9f3469d7a3fd39243ad66b46d6a54d > src/slave/containerizer/mesos/containerizer.cpp > fa40d47aee7803833bcde6cce1e86a21d7cf27d0 > src/tests/persistent_volume_tests.cpp > e3a8d33b6ae2b6afe5f4ab7c029b2f37a861f112 > > Diff: https://reviews.apache.org/r/30510/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
