----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30736/#review71897 -----------------------------------------------------------
So after looking at this review, I'm not sure we really need to add anything to Mesos, as getting graphic compute units and memory could be a seperate process/script that just injects the resources via the slave flags. On the framework side it could simply look up the resources by name, since the methods you added is only relevant if frameworks links with Mesos itself - Timothy Chen On Feb. 6, 2015, 5:33 p.m., chester kuo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30736/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2015, 5:33 p.m.) > > > Review request for mesos, Adam B and Timothy Chen. > > > Bugs: MESOS-2262 > https://issues.apache.org/jira/browse/MESOS-2262 > > > Repository: mesos > > > Description > ------- > > Extending Mesos to support Heterogeneous resource such as GPGPU/FPGA..etc as > computing resources in the data-center, OpenCL will be first target to add > into Mesos. > > This is first draft, some slave resouce discover not ready but i plan to work > on a framework first so we can have people to test it early. > > > Diffs > ----- > > configure.ac acc685caa47717f0fb61a7c18572d7b763ec707b > include/mesos/resources.hpp 3b57568c10233a0c692787de6464f21af5eaadf4 > src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc > src/common/resources.cpp 98371f6873482d0cdbefeb279b58ae6cc680a88f > src/examples/test_opencl_executor.cpp PRE-CREATION > src/examples/test_opencl_framework.cpp PRE-CREATION > src/slave/containerizer/containerizer.cpp > cf2ece80252350c25db38116e29cf28a3164662d > src/tests/master_allocator_tests.cpp > 1eebefd2e423e4bb89d76ed7b7d8acc9d1bb7760 > src/tests/master_tests.cpp 62ba35b9c3f999c59a95bffb01b8b82cc543a34f > > Diff: https://reviews.apache.org/r/30736/diff/ > > > Testing > ------- > > make check > & > I also create a simple frame test (test-opencl-framework so it can have a > quick smoke test) > > > Thanks, > > chester kuo > >
