----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30873/#review72100 -----------------------------------------------------------
Patch looks great! Reviews applied: [30873] All tests passed. - Mesos ReviewBot On Feb. 12, 2015, 1:33 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30873/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 1:33 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > ## Overview > > We'll shortly be allowing operators to dynamically change the reservation > configurations of slaves as well. At which point the words `STATIC` and > `DYNAMIC` are no longer accurate since the `STATIC` reservations would also > be dynamic. We change the terminology here to indicate the source of the > reservation, the reserver. > > ## Changes > > * `ReservationType` => `ReserverType` > * `STATIC` => `SLAVE` > * `DYNAMIC` => `FRAMEWORK` > > ## Remark > > 1. In `ReserverType`, 0 and 2 are left out for `NONE=0` and `OPERATOR=2` > which we plan to introduce later on. > 2. This is marked WIP (Work in Progress) since the design of this hasn't been > fully approved yet. > This chain of review requests are essentially a prototype. > > > Diffs > ----- > > include/mesos/mesos.proto 3a2921dff856d37455593dcbf7340aa537997d35 > src/master/allocator.hpp 2149ea48dd8614dc29350efaddcb43b6a082a43e > src/master/master.hpp 6a39df04514c756415354fae66c5835ada191c52 > src/messages/messages.proto 55b3a24ed05c04eaafc27243477bfc778a72b1d4 > src/slave/slave.cpp f39a876cdd6b580a7a75fd053e6923761bee7635 > > Diff: https://reviews.apache.org/r/30873/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
