> On Feb. 11, 2015, 5:58 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, line 405 > > <https://reviews.apache.org/r/29289/diff/14/?file=860864#file860864line405> > > > > add a TODO to test IPv6 HTTP stuff.
added - Evelina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29289/#review71980 ----------------------------------------------------------- On Feb. 12, 2015, 5:47 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29289/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 5:47 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos > > > Description > ------- > > Created the inner class InAddrStorage encapsulated inside the IP class. > The class uses a union with the in_addr and in6_addr fields. > I considered that the The MasterInfo protobuffers should have both an ipv4 > and an ipv6 field. > I intend to use the same Classifiers, addition, removal and update of > container filters, but write different encode/decode functions for IPv4/ICMP > and IPv6/ICMPv6 because the processing of the protocol headers differ. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/address.hpp > f5fb4dd2fdeaade36390c083bee6f2787df4b6d3 > 3rdparty/libprocess/include/process/network.hpp > 7620278e4b2c376e37353325aa717fe54b819272 > 3rdparty/libprocess/include/process/pid.hpp > 30c466c8defb45bbfaaf68611fb68285a89fea6e > 3rdparty/libprocess/include/process/socket.hpp > 426b3faaaed3cb1bd45170ddb77bdf54a1b28ded > 3rdparty/libprocess/src/http.cpp 7503313312cdcde4027c7dd106a3d7147a948038 > 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd > 3rdparty/libprocess/src/process.cpp > 425120b8ef2832f33a13392fe0f397e7b771c0c2 > 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 > 3rdparty/libprocess/src/tests/http_tests.cpp > 0a00ae59fe999344eb05bee04ab3fb703a3265e7 > 3rdparty/libprocess/src/tests/process_tests.cpp > 9f9220ebc05b66b15baa11295fd76c304be3b257 > > Diff: https://reviews.apache.org/r/29289/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
