----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30952/#review72442 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/30952/#comment118497> missing space. ```c++ static void checkId(scheduler::Call::Accept& mcall, const FrameworkID& id) ``` Should we change the name of this function, and add a comment? checkId suggests it doesn't mutate state (only validates). This function actually does mutate. src/master/master.cpp <https://reviews.apache.org/r/30952/#comment118500> Can you use a name that is more self-explanatory than mcall please? src/master/master.cpp <https://reviews.apache.org/r/30952/#comment118501> Can we put braces around multi-line case statements? ```c++ switch (val) { case 1: { ... break; } case 1: { ... break; } } ``` - Joris Van Remoortere On Feb. 13, 2015, 6:54 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30952/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 6:54 p.m.) > > > Review request for mesos, Jie Yu, Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-2290 > https://issues.apache.org/jira/browse/MESOS-2290 > > > Repository: mesos-incubating > > > Description > ------- > > There is a scheduler validation > (https://github.com/apache/mesos/blob/master/src/scheduler/scheduler.cpp#L275) > missing in master. See motivation on MESOS-2288. > > > Diffs > ----- > > src/master/master.cpp d04b2c4 > > Diff: https://reviews.apache.org/r/30952/diff/ > > > Testing > ------- > > make check and distcheck. Tests will be added with new HTTP API endpoints > tests. > > > Thanks, > > Isabel Jimenez > >
