----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30874/#review72533 -----------------------------------------------------------
Patch looks great! Reviews applied: [30873, 29742, 30911, 28698, 30874] All tests passed. - Mesos ReviewBot On Feb. 14, 2015, 1:22 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30874/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2015, 1:22 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > ## Overview > > With framework reservations, the allocator's `RoleSorter` needs to account > for framework reservations as well as unreserved resources. > > This patch introduces a predicate `isDRFAccounted` which filters for > resources that need to be accounted for RoleSorter's DRF accounting. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 2680d6231927867d5a8d75cbc42b81d6c75fc7f2 > > Diff: https://reviews.apache.org/r/30874/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
