----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31139/#review72841 -----------------------------------------------------------
3rdparty/libprocess/src/libev.cpp <https://reviews.apache.org/r/31139/#comment118946> reinterpret_cast<void*>(..) is unnecessary but provides some documentation. 3rdparty/libprocess/src/libevent.cpp <https://reviews.apache.org/r/31139/#comment118947> explicit on one-arg constructors please. - Dominic Hamon On Feb. 17, 2015, 4:27 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31139/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 4:27 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > This allows us to pass arbitrary state along (by binding it into the lambda) > with each delay call so we don't lose track of why we're being called back. > > > Diffs > ----- > > 3rdparty/libprocess/src/event_loop.hpp > 34e9f1dc95dcc4ee2bd1793e71725907f281c5c8 > 3rdparty/libprocess/src/libev.cpp 0e8d44cdc1daa258faafc30b5caf4a827ce6cbc1 > 3rdparty/libprocess/src/libevent.cpp > 28c2cf7f49cc153158f2a470a1812e35f7d4b93a > > Diff: https://reviews.apache.org/r/31139/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Joris Van Remoortere > >
