----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31141/#review72888 -----------------------------------------------------------
Ship it! Ship It! - Joris Van Remoortere On Feb. 18, 2015, 3:11 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31141/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 3:11 a.m.) > > > Review request for mesos, Benjamin Hindman and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > When the clock is paused, `next()` should return `None()` since no timers can > fire until the clock is advanced or updated. > > As a regression during the re-factoring, the `Clock::now()` used to schedule > these timers can now be called when `__process__` is set! That led to a flaky > test when applying the above fix. > > > Diffs > ----- > > 3rdparty/libprocess/src/clock.cpp b92d5de2631986506361e28c05cb6169e6632a70 > > Diff: https://reviews.apache.org/r/31141/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
