----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30971/#review73242 -----------------------------------------------------------
Ship it! include/mesos/mesos.proto <https://reviews.apache.org/r/30971/#comment119519> s/once it/once if it/ include/mesos/scheduler.hpp <https://reviews.apache.org/r/30971/#comment119522> Any reason not to just: Status acknowledge(const TaskStatus& status) = 0; Then down below you can do a 'status.has_uuid()'. include/mesos/scheduler.hpp <https://reviews.apache.org/r/30971/#comment119520> Can we put a newline between these please? src/sched/sched.cpp <https://reviews.apache.org/r/30971/#comment119521> s/uuid/UUID/ s/id/ID/ Acronyms! src/sched/sched.cpp <https://reviews.apache.org/r/30971/#comment119524> Rather than 'abort()' we should use ABORT() << "message"; - Benjamin Hindman On Feb. 18, 2015, 11:43 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30971/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 11:43 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-2347 > https://issues.apache.org/jira/browse/MESOS-2347 > > > Repository: mesos > > > Description > ------- > > Introduced explicit status update acknowledgements on the driver. > > > Diffs > ----- > > include/mesos/mesos.proto 507845c493f65e154214fc7e562206e452990469 > include/mesos/scheduler.hpp 31256c1c471232b5d879290e1b8ad914d26cf7a0 > src/sched/sched.cpp ea7e447e522f8fa335ee5dbdc6d65d4018042905 > src/scheduler/scheduler.cpp 5816569dc9cfeb86fe59b8fbea1518825b403182 > > Diff: https://reviews.apache.org/r/30971/diff/ > > > Testing > ------- > > Added tests in subsequent reviews. > > > Thanks, > > Ben Mahler > >
