Sorry about that! I just relaxed the perms so can anyone can edit/comment. Tim
On Thu, Feb 19, 2015 at 7:58 PM, Vinod Kone <vinodk...@gmail.com> wrote: > Thanks Tim for the doc. Can you open it up for comments (it's currently view > only)? > > On Thu, Feb 19, 2015 at 5:15 PM, Timothy Chen <tnac...@apache.org> wrote: >> >> >> >> > On Jan. 17, 2015, 1:39 a.m., Ben Mahler wrote: >> > > How are we going to manage the duplication across the command executor >> > > and the docker executor? >> > >> > Timothy Chen wrote: >> > I think I'm going to leave them seperate as they most likely will >> > grow independent in tangent. >> > The docker executor is solely responsible for launching docker >> > containers, and have different assumptions. >> > >> > Ben Mahler wrote: >> > Is there a design doc about this docker architecture decision? It's >> > a bit hard to see the context for this, and how this will play out for >> > other >> > executors that frameworks want to run inside docker, are you planning to >> > support that, or do users have to bake-in their executors..? >> > >> > Steve Niemitz wrote: >> > I'm curious about this too. I'm having trouble understanding how >> > other executors will run inside containers as they did previously after >> > this >> > change. I'd love to see a design doc about how this proposed system would >> > work. >> >> I've updated the Docker containerizer update google doc to hold a high >> level diagram with the new Docker executor. >> >> https://docs.google.com/a/mesosphere.io/document/d/1_1oLHXg_aHj_fYCzsjYwox9xvIYNAKIeVjO5BFxsUGI/edit >> >> >> - Timothy >> >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/29329/#review68533 >> ----------------------------------------------------------- >> >> >> On Jan. 17, 2015, 1:26 a.m., Timothy Chen wrote: >> > >> > ----------------------------------------------------------- >> > This is an automatically generated e-mail. To reply, visit: >> > https://reviews.apache.org/r/29329/ >> > ----------------------------------------------------------- >> > >> > (Updated Jan. 17, 2015, 1:26 a.m.) >> > >> > >> > Review request for mesos, Benjamin Hindman and Bernd Mathiske. >> > >> > >> > Repository: mesos >> > >> > >> > Description >> > ------- >> > >> > Add executor for docker containerizer, replaces the usage of command >> > executor >> > >> > >> > Diffs >> > ----- >> > >> > src/Makefile.am 07bea1f >> > src/docker/executor.cpp PRE-CREATION >> > >> > Diff: https://reviews.apache.org/r/29329/diff/ >> > >> > >> > Testing >> > ------- >> > >> > make check >> > >> > >> > Thanks, >> > >> > Timothy Chen >> > >> > >> >