----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31250/#review73360 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/31250/#comment119665> uint64? i hope we don't have more than 2^32 processes in a container! src/slave/containerizer/isolators/cgroups/cpushare.cpp <https://reviews.apache.org/r/31250/#comment119667> s/> >/>>/ src/slave/containerizer/isolators/cgroups/cpushare.cpp <https://reviews.apache.org/r/31250/#comment119670> does this scale linearly with number of processes? src/slave/containerizer/isolators/cgroups/cpushare.cpp <https://reviews.apache.org/r/31250/#comment119671> does this scale linearly with number of threads? - Dominic Hamon On Feb. 20, 2015, 5:12 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31250/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2015, 5:12 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: mesos-2103 > https://issues.apache.org/jira/browse/mesos-2103 > > > Repository: mesos > > > Description > ------- > > Ian, as discussed, I put the logic in cpu isolator for now until linux > launcher sees more and more need to report isolator-independent cgroup usage. > > > Diffs > ----- > > include/mesos/mesos.proto 507845c493f65e154214fc7e562206e452990469 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > e724b128f204e64a41561679c2797f81f64d1ab7 > src/tests/containerizer_tests.cpp 06788493c263e623644f8d4df8cca44a74800ebb > > Diff: https://reviews.apache.org/r/31250/diff/ > > > Testing > ------- > > added a new test. the test is end-to-end so that future replacement of the > actual logic won't require a change. > > > Thanks, > > Chi Zhang > >
