----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review73563 -----------------------------------------------------------
include/mesos/type_utils.hpp <https://reviews.apache.org/r/30931/#comment119956> move this further down, after the installed headers (those in sharp brackets). We generally have the following group ordering: 1. c standard headers (<.h>) 2. c installed headers (<.h>) 3. c++ standard headers (<>) 4. c++ installed headers (<.hpp>) 5. c++ internal, local headers (".hpp") All of the above get sorted alphabetically within their own group. include/mesos/type_utils.hpp <https://reviews.apache.org/r/30931/#comment119957> Are we missing a namespace close via bracket? src/common/type_utils.cpp <https://reviews.apache.org/r/30931/#comment119958> Maybe add a single space? src/slave/slave.cpp <https://reviews.apache.org/r/30931/#comment119959> How about supporting Mesos local and possibly the test as well? - Till Toenshoff On Feb. 13, 2015, 4:10 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30931/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 4:10 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-2323 > https://issues.apache.org/jira/browse/MESOS-2323 > > > Repository: mesos > > > Description > ------- > > Added flags to logs at master and slave startup. > > > Diffs > ----- > > include/mesos/type_utils.hpp 32dc6ed489f43ba3695507f59c4c2d94028c8df1 > src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6 > src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 > src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7 > > Diff: https://reviews.apache.org/r/30931/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >