-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31318/#review73667
-----------------------------------------------------------



src/tests/slave_tests.cpp
<https://reviews.apache.org/r/31318/#comment120061>

    according to our style guide we don't do this:
    
    "
    You may not use a using-directive to make all names from a namespace 
available.
    
    // Forbidden -- This pollutes the namespace.
    using namespace foo;
    "


- Dominic Hamon


On Feb. 23, 2015, 12:53 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31318/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 12:53 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2387
>     https://issues.apache.org/jira/browse/MESOS-2387
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the flaky test SlaveTest.TaskLaunchContainerizerUpdateFails.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 60c9f355020f09168d52aea1ea8f76cc50720528 
> 
> Diff: https://reviews.apache.org/r/31318/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to