> On Feb. 23, 2015, 12:32 p.m., Ben Mahler wrote: > > src/tests/master_slave_reconciliation_tests.cpp, lines 238-239 > > <https://reviews.apache.org/r/31315/diff/1/?file=873074#file873074line238> > > > > How about: > > > > ``` > > // Before we obtain the metrics, ensure that the master finishes > > // processesing the status update and increments its Counters. > > Clock::pause(); > > Clock::settle(); > > ``` > > Ben Mahler wrote: > That is, I'm hoping to avoid setting up an expectation on the > acknowledgement, as it's further removed from ensuring that the master > finishes processing the update.
done. Clock::resume also required or the metrics Future won't complete. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31315/#review73659 ----------------------------------------------------------- On Feb. 23, 2015, 11:56 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31315/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 11:56 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2366 > https://issues.apache.org/jira/browse/MESOS-2366 > > > Repository: mesos > > > Description > ------- > > Wait for status acknowledgement before getting master metrics > > > Diffs > ----- > > src/tests/master_slave_reconciliation_tests.cpp > 230f5293f4906e09eb55db128df4a19b1e308428 > > Diff: https://reviews.apache.org/r/31315/diff/ > > > Testing > ------- > > 300 repeats without failure of the test under a debugger. > > > Thanks, > > Dominic Hamon > >
