----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30900/#review73735 -----------------------------------------------------------
Ship it! Nice test, thanks! src/tests/persistent_volume_tests.cpp <https://reviews.apache.org/r/30900/#comment120115> Any reason not to just do s/ReregisterWithFailedOverMaster/MasterFailover/ ? src/tests/persistent_volume_tests.cpp <https://reviews.apache.org/r/30900/#comment120118> It seems like we often want to settle libprocess, not necessarily timers. Clock::settle has been conflated with settling libprocess, not just clock events. Do we want a process::settle() for testing to avoid pause/settle/resume on the Clock in cases like this? Just food for thought. - Ben Mahler On Feb. 11, 2015, 11:20 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30900/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 11:20 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added a persistent volume test for verifying master failover. > > Followup for https://reviews.apache.org/r/30812/ > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > b4f2298069233b27f6b4b8d668753810f43bb58d > > Diff: https://reviews.apache.org/r/30900/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
