----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31337/#review73833 -----------------------------------------------------------
Ship it! src/tests/launcher.hpp <https://reviews.apache.org/r/31337/#comment120238> Move this to the top? src/tests/launcher.hpp <https://reviews.apache.org/r/31337/#comment120236> This looks a little jagged. Maybe the following? ``` MOCK_METHOD9( fork, Try<pid_T>( const ContainerID& containerId, xxx xxx)); ``` - Jie Yu On Feb. 24, 2015, 1:52 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31337/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 1:52 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-1690 > https://issues.apache.org/jira/browse/MESOS-1690 > > > Repository: mesos > > > Description > ------- > > Needed for subsequent review. > > > Diffs > ----- > > src/Makefile.am 65cba64834d8d2224761105516c64c6ba203f9f3 > src/tests/launcher.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/31337/diff/ > > > Testing > ------- > > Tested in subsequent review. > > > Thanks, > > Vinod Kone > >
