----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31390/#review73997 -----------------------------------------------------------
Ship it! Looks great, although potentially more verbose than necessary. docs/app-framework-development-guide.md <https://reviews.apache.org/r/31390/#comment120436> Do you really need to bother showing the definition of Port[s] here? You don't copy the definition of Labels, and that's another DiscoveryInfo member type. Anybody getting that deep into it can/will go directly to the protobuf definitions anyway. docs/app-framework-development-guide.md <https://reviews.apache.org/r/31390/#comment120435> Do you really need to include this lengthy comment if you're copying its contents below? Once is enough. Your choice which one. - Adam B On Feb. 24, 2015, 9:38 p.m., Christos Kozyrakis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31390/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 9:38 p.m.) > > > Review request for mesos, Connor Doyle and Niklas Nielsen. > > > Bugs: MESOS-2396 > https://issues.apache.org/jira/browse/MESOS-2396 > > > Repository: mesos > > > Description > ------- > > Added discovery info documentation. > > > Diffs > ----- > > docs/app-framework-development-guide.md > dd7603d099f7582fa8fe93a4c3daa521b23f6223 > > Diff: https://reviews.apache.org/r/31390/diff/ > > > Testing > ------- > > > Thanks, > > Christos Kozyrakis > >
