----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31442/#review74117 -----------------------------------------------------------
src/linux/fs.cpp <https://reviews.apache.org/r/31442/#comment120638> check that new_root and put_old are directories. check that new_root and put_old are not on the same file system? check that put_old is underneath new_root. yes, these should be checked in the syscall, but the errors might not be clear (EINVAL, ENOTDIR, and EBUSY). - Dominic Hamon On Feb. 25, 2015, 2:31 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31442/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 2:31 p.m.) > > > Review request for mesos, Dominic Hamon and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Add Linux pivot_root() wrapper. > > > Diffs > ----- > > src/linux/fs.hpp ac8b5f416dae0a9388a3839b6f078abdcd42edae > src/linux/fs.cpp b01d14c3a1b296566b2b17a7f540097bd7cc53dd > > Diff: https://reviews.apache.org/r/31442/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
