> On Feb. 25, 2015, 3:17 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 405-430 > > <https://reviews.apache.org/r/31440/diff/1/?file=876471#file876471line405> > > > > Consider moving these to stout/stat.hpp and rename them to be: > > > > os::stat::islink > > os::stat::isfile > > os::stat::isdir > > > > os::stat::rdev > > os::stat::mode > > os::stat::mtime > > > > Thoughts?
+1 much cleaner. also tests :) - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31440/#review74141 ----------------------------------------------------------- On Feb. 25, 2015, 2:31 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31440/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 2:31 p.m.) > > > Review request for mesos, Dominic Hamon and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Add os::getmode() wrapper. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 8a4fda97ee29c185471a69f60803efc193cbe922 > > Diff: https://reviews.apache.org/r/31440/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
