> On Feb. 23, 2015, 4:05 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 409 > > <https://reviews.apache.org/r/30609/diff/3/?file=859975#file859975line409> > > > > I was quite confused by the "ownsize" name, I think everyone will be > > too, since it's a term no one is familiar with. > > > > I'm more in favor of just size, but looks like you want to distinguish > > getting the size of the symbolic link or the actual linked file size. > > > > How about we add a option to follow the link or not?
Brilliant! Thanks! - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30609/#review73716 ----------------------------------------------------------- On Feb. 22, 2015, 11:02 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30609/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2015, 11:02 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and > Timothy Chen. > > > Bugs: MESOS-2072 > https://issues.apache.org/jira/browse/MESOS-2072 > > > Repository: mesos > > > Description > ------- > > This returns a file's size (on UNIXes as reported by lstat(), not stat()). It > is desired that in case of a link, the size of the link, not the size of the > referenced file, is returned. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 8a4fda97ee29c185471a69f60803efc193cbe922 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 8a2d445c2edaa70da0e7b50e14ef88b2d9224a16 > > Diff: https://reviews.apache.org/r/30609/diff/ > > > Testing > ------- > > Wrote a simple test that creates a file and tests its size, and also checks > if a non-existing file yields an error. > > > Thanks, > > Bernd Mathiske > >
