> On Feb. 26, 2015, 10:47 a.m., Dominic Hamon wrote: > > i don't see the change to the actual method here.. > > Evelina Dumitrescu wrote: > The changes are in the fromLinkDevice test > ie: net::IPNetwork::fromLinkDevice(link, AF_INET); instead of > net::fromLinkDevice(link, AF_INET);
this review should also have the change in ip.hpp shouldn't they? - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31472/#review74320 ----------------------------------------------------------- On Feb. 25, 2015, 10:41 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31472/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 10:41 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van > Remoortere, and Niklas Nielsen. > > > Repository: mesos > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp > fb98317a68986cb1228c584a8cd83b07737895a8 > > Diff: https://reviews.apache.org/r/31472/diff/ > > > Testing > ------- > > > Thanks, > > Evelina Dumitrescu > >
