----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31443/#review74359 -----------------------------------------------------------
Ship it! src/linux/fs.hpp <https://reviews.apache.org/r/31443/#comment120926> Can you also adjust the comment here because the source can be a directory as well (in the case of bind mount). src/linux/fs.hpp <https://reviews.apache.org/r/31443/#comment120927> I guess you need to explain what does a "dummy argument" mean here. It gets a little confusing initially and I need to look into documents to find out what does that mean. Maybe say that source is optional. If not specified, it means xxx. src/linux/fs.hpp <https://reviews.apache.org/r/31443/#comment120928> Ditto above. Maybe just say that file system type is optional. Also, can you do a sweep in the code base to replace "none" with None()? I think we did use "none" in some cases for bind mounts. src/linux/fs.cpp <https://reviews.apache.org/r/31443/#comment120929> I think we can just return ErrnoError() here. It's caller's responsibility to print all arguments. src/linux/fs.cpp <https://reviews.apache.org/r/31443/#comment120930> Ditto here. No need to print 'target'. - Jie Yu On Feb. 25, 2015, 10:31 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31443/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 10:31 p.m.) > > > Review request for mesos, Dominic Hamon and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Accept dummy arguments for fs::mount(). > > > Diffs > ----- > > src/linux/fs.hpp ac8b5f416dae0a9388a3839b6f078abdcd42edae > src/linux/fs.cpp b01d14c3a1b296566b2b17a7f540097bd7cc53dd > > Diff: https://reviews.apache.org/r/31443/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
