----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31502/#review74389 -----------------------------------------------------------
src/Makefile.am <https://reviews.apache.org/r/31502/#comment120961> alphabetical order please. src/linux/routing/queueing/fq_codel.hpp <https://reviews.apache.org/r/31502/#comment120963> static is a better fit than extern for this. also does it actually have to be in the header? src/linux/routing/queueing/fq_codel.cpp <https://reviews.apache.org/r/31502/#comment120967> to simplify the namespace open and close, maybe forward declare this here and define it below 105? src/linux/routing/queueing/fq_codel.cpp <https://reviews.apache.org/r/31502/#comment120965> you have consts for EGRESS_ROOT and HANDLE, why not "fq_codel"? src/linux/routing/queueing/fq_codel.cpp <https://reviews.apache.org/r/31502/#comment120966> is this used? - Dominic Hamon On Feb. 26, 2015, 3:14 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31502/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 3:14 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Fq_codel qdisc is needed for egress flow classification. Internally fq_codel > defines its own flows, and it allows us to specifiy the rule to classify the > flows with tc filters attached on it. By default it has 1024 flows, much more > than the number of containers we could create on a single host. > > > Diffs > ----- > > src/Makefile.am 17d0d7aa7361c3a373f6863d36b0a4767f5c05c4 > src/linux/routing/queueing/fq_codel.hpp PRE-CREATION > src/linux/routing/queueing/fq_codel.cpp PRE-CREATION > src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5 > > Diff: https://reviews.apache.org/r/31502/diff/ > > > Testing > ------- > > Run the testcase. > > > Thanks, > > Cong Wang > >
