----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29288/#review74530 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp <https://reviews.apache.org/r/29288/#comment121120> the break is odd here. maybe try if (inet_ntop( AF_INET6, &ipv6Storage buffer, INET6_ADDRSTRLEN) == NULL) { what do you think? 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp <https://reviews.apache.org/r/29288/#comment121121> API thought: static const net::IPNetwork& loopback(int family); is that cleaner than two methods? 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp <https://reviews.apache.org/r/29288/#comment121122> Try<IP> networkToHostNetmask = IP::networkToHost( IP(*(sockaddr_in6*) ifa->ifa_netmask)); and lose netm - Dominic Hamon On Feb. 27, 2015, 1:23 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29288/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 1:23 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos > > > Description > ------- > > Created the inner class InAddrStorage encapsulated inside the IP class. > The class uses a union with the in_addr and in6_addr fields. > I considered that the The MasterInfo protobuffers should have both an ipv4 > and an ipv6 field. > I intend to use the same Classifiers, addition, removal and update of > container filters, but write different encode/decode functions for IPv4/ICMP > and IPv6/ICMPv6 because the processing of the protocol headers differ. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp > 3293086a009a8f7cf7bd343eb7d3e85623636550 > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > 9635bbc6f7dae1d75a780069fcc60fb706221053 > 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp > fb98317a68986cb1228c584a8cd83b07737895a8 > > Diff: https://reviews.apache.org/r/29288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
