Hi Dharmesh, Sounds great, thanks for taking a closer look! Can you attach your patch to one of the JIRA issues below and pass along the link? I can help review it and see that it's committed.
Thanks! Dave On Sun, Mar 1, 2015, at 01:53 AM, Dharmesh Kakadia wrote: > Hi Dave, > > I have finally got some time to look at the regex you mentioned and > indeed > thats what was the issue. I have fixed it but I don't know how to send > review request for the "site". I suppose "site" is not maintained in the > "repo". Can you please help me with that? Actual change is just one > character (:P), but I wanted to update the site README as well, as it > would > make the process clearer for newbies like me. > > Thanks, > Dharmesh > > On Sat, Nov 15, 2014 at 11:23 PM, Dharmesh Kakadia <[email protected]> > wrote: > > > Thanks Dave, Vinod and Adam. I will look into this. I will have to find > > some ruby before that :) > > > > Thanks, > > Dharmesh > > > > On Fri, Nov 14, 2014 at 2:20 AM, Adam Bordelon <[email protected]> wrote: > > > >> Here are some relevant JIRAs I found: > >> https://issues.apache.org/jira/browse/MESOS-934 - Mentions #1 > >> https://issues.apache.org/jira/browse/MESOS-1521 - Mentions #2 > >> > >> On Thu, Nov 13, 2014 at 12:22 PM, Dave Lester <[email protected]> > >> wrote: > >> > >> > Contributions are welcome! The website is available on subversion > >> > https://svn.apache.org/repos/asf/mesos/site/, which ingests docs from > >> the > >> > /docs/ folder of the main code repo, and will render the markdown files > >> on > >> > the site. There's a README in that directory with some instructions for > >> > building the site. > >> > > >> > On #1 and #2, I believe this is an issue with the regex that generates > >> docs > >> > when renders on the website. Check out the website's Rakefile which > >> > includes some ruby code to parse links and remove the .md extensions > >> from > >> > them. I believe there are already JIRA issues tracking these issues. > >> > > >> > On #3, the files were not previously uploaded however I fixed that the > >> > other day. > >> > > >> > On Thu, Nov 13, 2014 at 12:16 PM, Vinod Kone <[email protected]> > >> wrote: > >> > > >> > > + Dave > >> > > > >> > > Dave, can you guide Dharmesh here? > >> > > > >> > > On Mon, Nov 10, 2014 at 7:50 AM, Dharmesh Kakadia < > >> [email protected]> > >> > > wrote: > >> > > > >> > > > Hi, > >> > > > > >> > > > Following are dangling links in the documentation on Apache website. > >> > > > > >> > > > 1. Google blog link in > >> > > > http://mesos.apache.org/documentation/latest/logging-and-debugging/ > >> > > > 2. High Availability link on > >> > > > http://mesos.apache.org/documentation/latest/deploy-scripts/. > >> > > > 3. Mesos Modules link on the documentation home. > >> > > > > >> > > > Also, there is no link from documentation home to reach to the > >> > > > deploy-scripts page. All of the links are rendered correctly on the > >> > > github, > >> > > > but not on the website. I would be happy to help, but I don’t quite > >> > > > understand what is the problem. Can anyone guide me? > >> > > > > >> > > > Also, Mesos-submit is no longer part of the Mesos. Should we remove > >> the > >> > > > mesos-submit from the docs? I see a few pending PR for docs that > >> just > >> > > > require rebasing. I can take a shot at that too, if thats fine with > >> > > > everyone. > >> > > > > >> > > > Lets make docs as good as Mesos :) > >> > > > > >> > > > Thanks, > >> > > > Dharmesh > >> > > > > >> > > > > >> > > > >> > > >> > > > >
