> On March 2, 2015, 7:44 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/time.hpp, line 94 > > <https://reviews.apache.org/r/31518/diff/1/?file=879212#file879212line94> > > > > This should be PLOG instead of directly printing the error number? > > > > ``` > > PLOG(ERROR) << "Failed to convert Time to a tm, gmtime_r"; > > ```
this has been committed. i'll push a fix for this shortly. > On March 2, 2015, 7:44 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/encoder.hpp, lines 184-185 > > <https://reviews.apache.org/r/31518/diff/1/?file=879213#file879213line184> > > > > Ditto here, the errno isn't very informative, can you use PLOG or > > capture an ErrnoError to print the reason? converted this to a PCHECK. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31518/#review74803 ----------------------------------------------------------- On Feb. 27, 2015, 1:12 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31518/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 1:12 a.m.) > > > Review request for mesos, Jie Yu and Niklas Nielsen. > > > Bugs: MESOS-2407 > https://issues.apache.org/jira/browse/MESOS-2407 > > > Repository: mesos > > > Description > ------- > > Fixes one of the issues mentioned in MESOS-2407. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/time.hpp > 0803dc573df3b4a63d521e4d05e0f2b7113293df > 3rdparty/libprocess/src/encoder.hpp > 52dfd7f93ec465e4ec7c80addd491f229fb5081e > > Diff: https://reviews.apache.org/r/31518/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
