> On March 2, 2015, 9:38 p.m., Jie Yu wrote: > > src/linux/routing/filter/action.hpp, line 76 > > <https://reviews.apache.org/r/31503/diff/1/?file=879070#file879070line76> > > > > The name `Classifier` here is a little confusing because we already > > have `ip::Classifier`, `icmp::Classifier` and `arc::Classifier`. > > > > How about renaming it to `Flow` since the tc command uses `flowid`?
I rename it to FlowId. - Cong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/#review74787 ----------------------------------------------------------- On Feb. 27, 2015, 9:39 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31503/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 9:39 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2422 > https://issues.apache.org/jira/browse/MESOS-2422 > > > Repository: mesos > > > Description > ------- > > Introduce a new action which saves the classid for a specified filter. > Similar to the u32 terminal action, it is not a real action defined by TC, it > is just for setting a filter attribute. The classid or flowid is used to > match the fq_codel flows. > > > Diffs > ----- > > src/linux/routing/filter/action.hpp > 410c15ad20ffa694bdb4c4187f1544ef9617ebac > src/linux/routing/filter/arp.hpp fa0ea6f93218fb3bee9f435f0268022d5edc5e11 > src/linux/routing/filter/arp.cpp bf19264ccc83e8a8b8c2affe53779ac070472925 > src/linux/routing/filter/icmp.hpp 7b478c4e23a2fb0895021ce5fb30bdf78131b871 > src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d > src/linux/routing/filter/internal.hpp > 8a6c0c0390c4ed119a11f0f808e0a244f7734c45 > src/linux/routing/filter/ip.hpp 932ed4bbf57e60261ff3b48ae242a7dd5e1f4260 > src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2 > src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5 > > Diff: https://reviews.apache.org/r/31503/diff/ > > > Testing > ------- > > Run the testcase. > > > Thanks, > > Cong Wang > >
