> On March 3, 2015, 10:25 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 2519 > > <https://reviews.apache.org/r/31538/diff/3/?file=883016#file883016line2519> > > > > shouldn't this be "status.state() == TASK_STAGING" !?!? > > > > I'm surprised this passed 'make check'!?? > > > > This validation in the driver aborted the driver/executor. Now this > > validation in the slave silently drops this message without informing the > > driver. How about destroying the container instead for now to keep parity? > > With HTTP API this will probably just result in a "400 Bad Request" > > response.
+1 - Isabel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31538/#review75062 ----------------------------------------------------------- On March 3, 2015, 2:24 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31538/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 2:24 p.m.) > > > Review request for mesos, Isabel Jimenez and Till Toenshoff. > > > Bugs: mesos-2291 > https://issues.apache.org/jira/browse/mesos-2291 > > > Repository: mesos > > > Description > ------- > > Copies validations made to the messages exchanged between the slave and the > `MesosExecutorDriver` and performed in the executor driver to the slave. This > is requiered since the new HTTP API will deprecate the executor driver. > > > Diffs > ----- > > src/slave/slave.cpp a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2 > > Diff: https://reviews.apache.org/r/31538/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
