----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31250/#review73835 -----------------------------------------------------------
src/tests/isolator_tests.cpp <https://reviews.apache.org/r/31250/#comment120240> 0U .. processes() and threads() are unsigned. src/tests/isolator_tests.cpp <https://reviews.apache.org/r/31250/#comment120242> vector<string> argv{"sh", "-c", "sleep 1000"}; initializer lists! src/tests/isolator_tests.cpp <https://reviews.apache.org/r/31250/#comment120244> this is flaky. what if the below takes longer than expected? or someone thinks that changing this value to be smaller will speed up the test? maybe 'while true; do sleep 1s; done;' is better? src/tests/isolator_tests.cpp <https://reviews.apache.org/r/31250/#comment120243> s/> >/>>/ throughout. src/slave/flags.hpp <https://reviews.apache.org/r/31250/#comment122593> having this in slave makes me uncomfortable. it really should be somewhere like the isolator given that it's accessed only there. - Dominic Hamon On March 5, 2015, 6 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31250/ > ----------------------------------------------------------- > > (Updated March 5, 2015, 6 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: mesos-2103 > https://issues.apache.org/jira/browse/mesos-2103 > > > Repository: mesos > > > Description > ------- > > Ian, as discussed, I put the logic in cpu isolator for now until linux > launcher sees more and more need to report isolator-independent cgroup usage. > > > Diffs > ----- > > include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > d4967687241ddf50a85beb961d691a8974f24fea > src/slave/flags.hpp 56b25caf3901b38bdecb50310e8bcae0b114efa8 > src/tests/isolator_tests.cpp f7323965b94543bfda78afc4f60fc677f4900ecd > > Diff: https://reviews.apache.org/r/31250/diff/ > > > Testing > ------- > > added a new test. the test is end-to-end so that future replacement of the > actual logic won't require a change. > > > Thanks, > > Chi Zhang > >
