> On March 6, 2015, 11:28 p.m., Ben Mahler wrote: > > src/common/resources.cpp, lines 992-997 > > <https://reviews.apache.org/r/31664/diff/4/?file=887502#file887502line992> > > > > This looks inconsistent with all of the other + operator > > implementations in this file, no?
Reverted for consistency. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31664/#review75571 ----------------------------------------------------------- On March 7, 2015, 12:21 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31664/ > ----------------------------------------------------------- > > (Updated March 7, 2015, 12:21 a.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-2373 > https://issues.apache.org/jira/browse/MESOS-2373 > > > Repository: mesos > > > Description > ------- > > Convenience functions to help aggregate `hashmap<SlaveID, Resources>`. Used > in [r31665](https://reviews.apache.org/r/31665). > > > Diffs > ----- > > include/mesos/resources.hpp da6d48871a0061d8bbf5e681dd6e7edac659d812 > src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059 > > Diff: https://reviews.apache.org/r/31664/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
