----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/#review75999 -----------------------------------------------------------
Ship it! src/linux/routing/filter/arp.hpp <https://reviews.apache.org/r/31503/#comment123386> s/flowid/classid/ src/linux/routing/filter/arp.hpp <https://reviews.apache.org/r/31503/#comment123376> Can you consistently use `classid` for Filter? The word 'flowid' is used by the isolator and should be the lower 16 bits. src/linux/routing/filter/arp.cpp <https://reviews.apache.org/r/31503/#comment123381> Ditto. Please use 'classid' here. src/linux/routing/filter/arp.cpp <https://reviews.apache.org/r/31503/#comment123382> Ditto. src/linux/routing/filter/filter.hpp <https://reviews.apache.org/r/31503/#comment123383> Ha, you call it 'classid' here! src/linux/routing/filter/filter.hpp <https://reviews.apache.org/r/31503/#comment123385> WE may wanna add classful qdisc in the future. So just say that we use 'classid' consistently in the code base. src/linux/routing/filter/icmp.cpp <https://reviews.apache.org/r/31503/#comment123387> Ditto. src/linux/routing/filter/ip.hpp <https://reviews.apache.org/r/31503/#comment123389> Ditto. src/linux/routing/filter/ip.cpp <https://reviews.apache.org/r/31503/#comment123390> Ditto. src/linux/routing/queueing/handle.hpp <https://reviews.apache.org/r/31503/#comment123391> Please add a comment about this function. It's not quite obvious what this constructor is doing. - Jie Yu On March 10, 2015, 11:26 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31503/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 11:26 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2422 > https://issues.apache.org/jira/browse/MESOS-2422 > > > Repository: mesos > > > Description > ------- > > Currently we don't support to read actions, so intead of using an action, we > add the classid to the generic Filter class. Now it is much easier to read it > for recovery. > > > Diffs > ----- > > src/linux/routing/filter/arp.hpp fa0ea6f93218fb3bee9f435f0268022d5edc5e11 > src/linux/routing/filter/arp.cpp bf19264ccc83e8a8b8c2affe53779ac070472925 > src/linux/routing/filter/filter.hpp > d4ea099a2e35ffc0e6d560c5de9864dbbfe10038 > src/linux/routing/filter/icmp.hpp 431bc19eb600b0568874dacfce123adef0f9ff0b > src/linux/routing/filter/icmp.cpp 706b5d1871d9e0b79d1b869d27d0e87112b75975 > src/linux/routing/filter/internal.hpp > 8a6c0c0390c4ed119a11f0f808e0a244f7734c45 > src/linux/routing/filter/ip.hpp b5406024fdbfd1510bcf619f04a7369763396e72 > src/linux/routing/filter/ip.cpp de6407119c6726e0f32b07fd6ff61fa29262638b > src/linux/routing/queueing/handle.hpp > 2725d0794ca29ad5dc1b0148d0f68b90ce8b8369 > src/tests/routing_tests.cpp 7cc3b57a3b71544874557d2b1cf88a241b7062ba > > Diff: https://reviews.apache.org/r/31503/diff/ > > > Testing > ------- > > Run the testcase. > > > Thanks, > > Cong Wang > >
