----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31903/#review76110 -----------------------------------------------------------
Ship it! This patch looks good, but can you please include updates to the CHANGELOG and Upgrades documents in this review chain to capture this API change in 0.23.0? src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp <https://reviews.apache.org/r/31903/#comment123529> Can we get some newlines here? src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp <https://reviews.apache.org/r/31903/#comment123531> newline here? src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp <https://reviews.apache.org/r/31903/#comment123530> Can we get some newlines here? src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp <https://reviews.apache.org/r/31903/#comment123532> newline here? - Ben Mahler On March 10, 2015, 6:09 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31903/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 6:09 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Bugs: MESOS-2428 > https://issues.apache.org/jira/browse/MESOS-2428 > > > Repository: mesos > > > Description > ------- > > Added Python binding for the acceptOffers API. > > > Diffs > ----- > > src/examples/python/test_framework.py > 27106147900f8b5dd2ea0443f5658902ff1145e4 > src/python/interface/src/mesos/interface/__init__.py > f3d96a455dc8b66fc4527af1b3dee2f8841b29dd > src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp > a6980002202b829b40e85188bfb291e5d22c9a26 > src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp > bb1884597731c73f4815069ceb940cf067790670 > > Diff: https://reviews.apache.org/r/31903/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
