> On March 11, 2015, 3:30 p.m., Adam B wrote: > > src/slave/containerizer/containerizer.cpp, lines 295-302 > > <https://reviews.apache.org/r/31889/diff/9/?file=891672#file891672line295> > > > > What about other env[] variables set earlier in this function? If the > > decorator wants to check/modify "MESOS_DIRECTORY" or other MESOS_foo env > > variables, it won't know what they are being set to and will have to > > blindly override them if it wants to set them. > > > > Maybe we could pass a mutable copy of ExecutorInfo where the env[] > > variables have been merged in, or go back to passing env[] itself, after > > the executorInfo defaults have been set.
A nice to have for now IMO. We can leave a comment/TODO/JIRA but I think we should discuss whether we actually want the decorator to change internal environment variables. - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31889/#review76147 ----------------------------------------------------------- On March 11, 2015, 3:27 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31889/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 3:27 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Till > Toenshoff. > > > Bugs: MESOS-2463 > https://issues.apache.org/jira/browse/MESOS-2463 > > > Repository: mesos > > > Description > ------- > > The ExecutorInfo is immutable, and so the environment decoration is deferred > until containerizer launch. The new slaveExecutorHook simply notifies the hook > module of a new executor being launched. The environment decorator hook for > containerizer launch update it's environment variables as gathered from the > hook > modules. > > > Diffs > ----- > > include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef > src/examples/test_hook_module.cpp 22212261053f2c10f7c4e5ae15aa3d4a2aa1c051 > src/hook/manager.hpp d3729eaca1bf2893cbc94cf62835dafb2d9a22a1 > src/hook/manager.cpp 3fd9d5e7f81e3d0ca2aca4091beba4ae555ae7e7 > src/slave/containerizer/containerizer.cpp > 33f8738fa229b42ebacfd75b762c977b33191b65 > src/slave/slave.cpp 71ae84bbfcef208cc2ee603f3c8a79225e48a7d5 > src/tests/hook_tests.cpp b5d776a55b6b205394469c176ac6be6702c218f3 > > Diff: https://reviews.apache.org/r/31889/diff/ > > > Testing > ------- > > make check. Also tried a negative test by replacing `test $FOO = 'bar'` with > `test $FOO = 'baz'` and surely, the test failed. > > > Thanks, > > Kapil Arya > >
