> On March 11, 2015, 7:14 p.m., Ben Mahler wrote:
> > src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp, lines 902-903
> > <https://reviews.apache.org/r/31873/diff/1/?file=889870#file889870line902>
> >
> >     Want to collapse these lines to just `push_back(construct<...>(...));`

Done.


> On March 11, 2015, 7:14 p.m., Ben Mahler wrote:
> > src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp, lines 925-928
> > <https://reviews.apache.org/r/31873/diff/1/?file=889870#file889870line925>
> >
> >     Want to collapse these lines to just `push_back(construct<...>(...))`?

Done.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31873/#review76106
-----------------------------------------------------------


On March 10, 2015, 12:07 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31873/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 12:07 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-2427
>     https://issues.apache.org/jira/browse/MESOS-2427
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Java binding for the new acceptOffers API.
> 
> 
> Diffs
> -----
> 
>   src/examples/java/TestFramework.java 
> 65ba9d9e242f40d6382cd9c18269b87f8b59b5a1 
>   src/java/jni/construct.cpp e54c11ef0ce3e9f6d0e572d3a89cadae417f9cd6 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> 4f0dad78f7300b7bbf147f231eb053fd7faf4b69 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
> a1055a5d907133485891ebd6d8731c102b913fec 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> d5b100a4c371bd9c496b9127767c14047185e5f9 
> 
> Diff: https://reviews.apache.org/r/31873/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to