----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31324/#review76203 -----------------------------------------------------------
Ship it! Looks more or less good to go. I just want to call your attention to a few features that could use references to further documentation, and a couple of fixes/features that might warrant further note. CHANGELOG <https://reviews.apache.org/r/31324/#comment123681> Any doc to point to with more info? CHANGELOG <https://reviews.apache.org/r/31324/#comment123682> Again, doc reference? s/;/:/ CHANGELOG <https://reviews.apache.org/r/31324/#comment123683> Also in ExecutorInfo, but that's probably mentioned in the framework development guide. CHANGELOG <https://reviews.apache.org/r/31324/#comment123684> Where should users look for this information now? The JIRA leads me to believe '/metrics/snapshot', but we need to have a clear answer. Is there further documentation on the metrics endpoints? CHANGELOG <https://reviews.apache.org/r/31324/#comment123685> Possibly an API change, since custom resource types will now show up in slave's state.json, but not likely to break anything. CHANGELOG <https://reviews.apache.org/r/31324/#comment123686> Another potential API change/fix, for reconciliation status updates. This one feels even less likely to surprise anybody CHANGELOG <https://reviews.apache.org/r/31324/#comment123687> Do we want to call out libevent support as a new "feature"? Or go silent until SSL can be enabled? CHANGELOG <https://reviews.apache.org/r/31324/#comment123689> Are we leaving DiskInfo (Persistent Volumes) in silent mode as well, presumably due to a few missing pieces? CHANGELOG <https://reviews.apache.org/r/31324/#comment123688> Similarly, do we want to call out the new Accept(offerIds, Operation) API, or wait until DiskInfo/DynamicReservations are ready before we try and push people off of the old LaunchTasks API? - Adam B On March 11, 2015, 5:28 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31324/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 5:28 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Updated changelog for Mesos 0.22.0 > > > Diffs > ----- > > CHANGELOG 2a54f08b7bb9cc6983631268eafec8cb7d166d97 > > Diff: https://reviews.apache.org/r/31324/diff/ > > > Testing > ------- > > > Thanks, > > Niklas Nielsen > >
