> On March 12, 2015, 8:36 a.m., Adam B wrote: > > Looks like a solid fix. Is there a JIRA associated with this patch?
I'm not sure, I searched for `MasterFailoverLongLivedExecutor` but couldn't seem to find it in JIRA. > On March 12, 2015, 8:36 a.m., Adam B wrote: > > src/tests/master_tests.cpp, line 3214 > > <https://reviews.apache.org/r/31977/diff/1/?file=892033#file892033line3214> > > > > I found a couple other MATCHERs in > > 3rdparty/libprocess/include/process/gmock.hpp Yeah, I found those as well. I think the `MessageMatcher` and `DispatchMatcher` which are in `3rdparty/libprocess/include/process/gmock.hpp` belong there, but a `TaskStatusEq` probably does not. If we were to move it, as it stands `src/tests/mesos.hpp` is probably the best place. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31977/#review76218 ----------------------------------------------------------- On March 12, 2015, 7:53 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31977/ > ----------------------------------------------------------- > > (Updated March 12, 2015, 7:53 a.m.) > > > Review request for mesos, Adam B and Niklas Nielsen. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/master_tests.cpp e69348be676a80017062e3abbd15b8008a6009d7 > > Diff: https://reviews.apache.org/r/31977/diff/ > > > Testing > ------- > > 1. `GTEST_FILTER="MasterTest.MasterFailoverLongLivedExecutor" GLOG_v=1 > ./bin/mesos-tests.sh --gtest_repeat=-1` up to 500+ iterations > 2. `make check -j 8` > 3. `./bin/mesos-tests.sh --gtest_shuffle` > > > Thanks, > > Michael Park > >
