> On March 12, 2015, 6:29 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/process.cpp, line 2875 > > <https://reviews.apache.org/r/31997/diff/1/?file=892303#file892303line2875> > > > > CHECK_SOME(timer)?
Added, Should be impossible to get there without timer being set because of libprocess initialization ordering, but always better safe than sorry. - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31997/#review76266 ----------------------------------------------------------- On March 12, 2015, 6:34 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31997/ > ----------------------------------------------------------- > > (Updated March 12, 2015, 6:34 p.m.) > > > Review request for mesos, Ben Mahler and Joris Van Remoortere. > > > Bugs: MESOS-2484 > https://issues.apache.org/jira/browse/MESOS-2484 > > > Repository: mesos > > > Description > ------- > > Cleanup waiter timers so we don't send an event to a dead waiter > > Follow up for 30587 > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > e7b029ba97e640c2102548c190ba62b30602f43d > > Diff: https://reviews.apache.org/r/31997/diff/ > > > Testing > ------- > > `GLOG_v=1 make check` on ArchLinux, log messages don't show up for waiter > (just metrics). > > > Thanks, > > Cody Maloney > >
