----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31992/#review76271 -----------------------------------------------------------
* Braces: placed on separate line for class / struct / function definitions. Same line otherwise. Do we want to tackle higher level style here that is currently missing from the style guide? * Use Try / Result to describe functions that can fail synchronously (rather than returning NULL, -1, etc). * Use Option to capture something that is optionally set (rather than NULL, -1, etc). * Use Future failure to capture asychronous failures. * Do not block inside the execution context of a libprocess Process. - Ben Mahler On March 12, 2015, 3:59 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31992/ > ----------------------------------------------------------- > > (Updated March 12, 2015, 3:59 p.m.) > > > Review request for mesos, Bernd Mathiske and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > readability/TODO PRE-CREATION > > Diff: https://reviews.apache.org/r/31992/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Benjamin Hindman > >
