----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31700/#review76276 -----------------------------------------------------------
Ship it! Thanks Alex! Let's look at using std::move as well if that works on gcc 4.4 (since that's still inside configure.ac). src/common/http.cpp <https://reviews.apache.org/r/31700/#comment123796> Let's end all of these comments with a period. I'll take care of this before committing. - Ben Mahler On March 11, 2015, 10:40 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31700/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 10:40 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2353 > https://issues.apache.org/jira/browse/MESOS-2353 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/http.cpp 0b57fb01f7769031704e5341849bf95a0197ffd9 > src/master/http.cpp 0b56cb419b0e488eb4163739f57ee1837ca83d24 > > Diff: https://reviews.apache.org/r/31700/diff/ > > > Testing > ------- > > make check (OS X 10.9.5, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
