----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32008/ -----------------------------------------------------------
Review request for mesos, Niklas Nielsen and Timothy St. Clair. Bugs: MESOS-2486 https://issues.apache.org/jira/browse/MESOS-2486 Repository: mesos Description ------- When building with unbundled libraries, every program needs to link against the libraries, and can't assume it will be linked against because the program links with a program which links against the libraries. This comes up on Debian and Ubuntu[1] which set the flag `-Wl,--no-copy-dt-needed-entries` which forcibly disables the binaries from getting automatically the dependencies of the shared libraries they link against. Fixes MESOS-2486 [1] https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wl.2C--no-copy-dt-needed-entries Diffs ----- src/Makefile.am 3059818231c46484039d179cd6916932eff6cd68 Diff: https://reviews.apache.org/r/32008/diff/ Testing ------- make check on Ubuntu 14.04 with `--with-glog`, `--with-protobuf` and `--with-boost`. As a sanity check that all isntances of _LDADD are updated, I ran the grep: `grep -r _LDADD . | grep -v '$(LDADD)'` that all the program-specific LDADD flags now include the global LDADD. Thanks, Cody Maloney