> On March 13, 2015, 4:46 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 145 > > <https://reviews.apache.org/r/31930/diff/1/?file=891209#file891209line145> > > > > Also explain that this is an in-memory single OS process pipe, and is > > not backed by file descriptors so can't be used across a fork.
It says in-memory near the very top. I'll add a sentence after that one to call out that this cannot be used across OS processes, hopefully that further avoids possible confusion. > On March 13, 2015, 4:46 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 130 > > <https://reviews.apache.org/r/31930/diff/1/?file=891209#file891209line130> > > > > s/streaming HTTP data/sending an HTTP response via the chunked transfer > > encoding/ Such a comment is likely to change very soon, when we want to receive responses in a streaming manner. But I'll add it to be more specific for now. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31930/#review76236 ----------------------------------------------------------- On March 11, 2015, 7:41 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31930/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 7:41 a.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-2438 > https://issues.apache.org/jira/browse/MESOS-2438 > > > Repository: mesos > > > Description > ------- > > See MESOS-2438 for the motivation. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 10143fdbd5eb43f968c41957a2335f96a097d82e > 3rdparty/libprocess/src/http.cpp 7c0cee404645e1dd1a9253f85883aefa29a5f999 > 3rdparty/libprocess/src/process.cpp > e7b029ba97e640c2102548c190ba62b30602f43d > 3rdparty/libprocess/src/tests/http_tests.cpp > 800752a57230d7768d3d741fef87f6283757e424 > > Diff: https://reviews.apache.org/r/31930/diff/ > > > Testing > ------- > > * added tests > * make check > > > Thanks, > > Ben Mahler > >
