----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32130/#review76830 -----------------------------------------------------------
Ship it! modulo nik's comments. - Vinod Kone On March 17, 2015, 9:54 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32130/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 9:54 p.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-2499 > https://issues.apache.org/jira/browse/MESOS-2499 > > > Repository: mesos > > > Description > ------- > > A status update originating from executor should have the TaskStatus::source > field set to TaskStatus::SOURCE_EXECUTOR. Set this field in the slave to be > future proof (a future where there will be no executor driver). Previous code > has a bug and updated a copy of the update that was not forwarded. Add some > checks for source and reason for status updates in existing tests. > > NOTE: Passing argument by value instead of `const&` is not fully consistent > with our codebase, but not entirely alien; it also documents our intention. > This approach should be fine, since `install()` deduces argument types from > the return values of getter functions of protobuf messaged. > > > Diffs > ----- > > src/slave/slave.hpp 989832f8783d07d0702b30f0a68b8c383b57c621 > src/slave/slave.cpp 0f99e4efb8fa2b96f120a3e49191158ca0364c06 > src/tests/slave_tests.cpp a975305430097a8295b4b155e8448572c12bde22 > > Diff: https://reviews.apache.org/r/32130/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, CentOS 7.0.1406, g++-4.4 @ Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
