----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/#review77426 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp <https://reviews.apache.org/r/32105/#comment125485> As I see you create the body of a json object where all the elements are strings themselves, ignoring their actual types and in [30931](https://reviews.apache.org/r/30931/diff/) the outer brackets are added completing the json object. In the endpoints, for example [here](https://github.com/apache/mesos/blob/0c7104d4d83d28371db7d19dcbb1bf077eeede05/src/master/http.cpp#L108) we use a patter for serialisation where we create a json object through a `model` function, and then we serialise the resulting json. Is there a reason why that approach wouln't work here? - Alexander Rojas On March 17, 2015, 1:25 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32105/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 1:25 a.m.) > > > Review request for mesos. > > > Bugs: Mesos-2323 > https://issues.apache.org/jira/browse/Mesos-2323 > > > Repository: mesos > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > aedb6ab30d929b81f55270612e76009bd7850daa > > Diff: https://reviews.apache.org/r/32105/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
