----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32405/#review77758 -----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/32405/#comment125957> curious why the const is dropped? - Chi Zhang On March 23, 2015, 5:05 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32405/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 5:05 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-2528 > https://issues.apache.org/jira/browse/MESOS-2528 > > > Repository: mesos > > > Description > ------- > > Fixed the non-POD global variables in port mapping isolator. We should avoid > these non-POD global variables because it's evil during tear down in a > multithreaded envorinment. > > I also renamed VETH_PREFIX and BIND_MOUNT_ROOT to be PORT_MAPPING_VETH_PREFIX > and PORT_MAPPING_BIND_MOUNT_ROOT because the pid namespace isolator also has > BIND_MOUNT_ROOT defined. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp > 3aae7e264e9496804fd338f805bef31e79e2a153 > src/slave/containerizer/isolators/network/port_mapping.cpp > 7b4aac88d40e4e5dc3331cb19b647a1d872ef7e2 > src/tests/port_mapping_tests.cpp 82f98a47fa374fda13b0be76b07ccc03174a7b96 > > Diff: https://reviews.apache.org/r/32405/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
