> On March 18, 2015, 12:29 a.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 2412 > > <https://reviews.apache.org/r/32150/diff/1/?file=897366#file897366line2412> > > > > Should we log here? > > Michael Park wrote: > We log inside the `drop` function already. Do you mean we should log > around this particular call-site?
No, I missed the comment, sorry for the noise. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/#review76837 ----------------------------------------------------------- On March 19, 2015, 7:06 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32150/ > ----------------------------------------------------------- > > (Updated March 19, 2015, 7:06 p.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu. > > > Bugs: MESOS-2139 > https://issues.apache.org/jira/browse/MESOS-2139 > > > Repository: mesos > > > Description > ------- > > Handled reservation operations in `Master::_accept`. > > Added `validate` functions in `src/master/validation.{hpp,cpp}`. > > > Diffs > ----- > > src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 > src/master/validation.hpp 2d7416c053f82d6316542fa9c35b0e7bc605abec > src/master/validation.cpp 2f2e4ea8ea123c5a0d01446cdec8b308ea60932e > src/tests/master_validation_tests.cpp > c8742928a4e93e86ccd0f5a39856a65cfe8eb74f > > Diff: https://reviews.apache.org/r/32150/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
