> On March 24, 2015, 5:55 a.m., Michael Park wrote: > > > > Michael Park wrote: > Hm, upon looking at other files in `include/mesos/module/` it looks like > the 2 style issues I mentioned below is apparent in all of them. Is there a > reason for this? or shoud they be fixed as a batch in a separate review > request?
Yes, I followed the general pattern for modules here. Let's do a batch cleanup here: https://issues.apache.org/jira/browse/MESOS-2565 - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31266/#review77528 ----------------------------------------------------------- On March 23, 2015, 2:03 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31266/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 2:03 p.m.) > > > Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. > > > Bugs: MESOS-2160 > https://issues.apache.org/jira/browse/MESOS-2160 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/module/allocator.hpp PRE-CREATION > src/Makefile.am 7a06c7028eca8164b1f5fdea6a7ecd37ee6826bb > src/module/manager.cpp 82a38f06e57d034650a6ac32fd73527b38cc97b8 > > Diff: https://reviews.apache.org/r/31266/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, CentOS 7.0) > > > Thanks, > > Alexander Rukletsov > >
