> On March 24, 2015, 2:49 p.m., Michael Park wrote: > > src/tests/master_allocator_tests.cpp, lines 123-126 > > <https://reviews.apache.org/r/31268/diff/4/?file=903030#file903030line123> > > > > Could we indent this similar to this example from > > `src/tests/isolator_tests.cpp`: > > > > ``` > > typedef ::testing::Types< > > CgroupsMemIsolatorProcess, > > CgroupsCpushareIsolatorProcess, > > CgroupsPerfEventIsolatorProcess> CgroupsIsolatorTypes; > > ``` > > > > ``` > > typedef ::testing::Types< > > HierarchicalDRFAllocator, > > tests::Module<Allocator, TestDRFAllocator>> AllocatorTypes; > > ```
I don't know what is consistent here, `src/tests/cram_md5_authentication_tests.cpp` use the indentation I use. Also, clang-format gives something that is more similar to the way I propose. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/#review77572 ----------------------------------------------------------- On March 23, 2015, 2:27 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31268/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 2:27 p.m.) > > > Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. > > > Bugs: MESOS-2160 > https://issues.apache.org/jira/browse/MESOS-2160 > > > Repository: mesos > > > Description > ------- > > Same typed tests are used for built-in and modularized allocators. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp > a432d0207e1a92532a495bf9ad2826414ee4f6f0 > > Diff: https://reviews.apache.org/r/31268/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, CentOS 7.0) > > > Thanks, > > Alexander Rukletsov > >
