----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32550/#review78080 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp <https://reviews.apache.org/r/32550/#comment126483> These are const, let's just expose them as fields (without the _), like we do for os::Release. - Benjamin Hindman On March 27, 2015, 12:01 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32550/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 12:01 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1795 and MESOS-2161 > https://issues.apache.org/jira/browse/MESOS-1795 > https://issues.apache.org/jira/browse/MESOS-2161 > > > Repository: mesos > > > Description > ------- > > We called them majorVersion, minorVersion, and patchVersion to avoid > conflicting with major() and minor() (http://man.he.net/man3/gnu_dev_major) > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp > 090fcf09dd96538a8748cf4443d150911e2c0d27 > > Diff: https://reviews.apache.org/r/32550/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
