----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32152/#review78092 -----------------------------------------------------------
Ship it! src/java/jni/org_apache_mesos_state_AbstractState.cpp <https://reviews.apache.org/r/32152/#comment126525> s/.././ src/java/jni/org_apache_mesos_state_AbstractState.cpp <https://reviews.apache.org/r/32152/#comment126519> Can we confirm that we can make a jclass be static? src/java/jni/org_apache_mesos_state_AbstractState.cpp <https://reviews.apache.org/r/32152/#comment126524> Please add a minor comment above each of these 'return' lines that says something like: // NOTE: See TODO at top of file for why we proxy. src/java/jni/org_apache_mesos_state_AbstractState.cpp <https://reviews.apache.org/r/32152/#comment126523> 4 space indent src/java/jni/org_apache_mesos_state_AbstractState.cpp <https://reviews.apache.org/r/32152/#comment126517> Kill whitespace please. src/java/src/org/apache/mesos/state/AbstractState.java <https://reviews.apache.org/r/32152/#comment126520> Can kill the 'try' once we change MesosNativeLibrary.LibraryNotLoadedException to RuntimeException. Here and below. - Benjamin Hindman On March 27, 2015, 12:02 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32152/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 12:02 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1795 and MESOS-2161 > https://issues.apache.org/jira/browse/MESOS-1795 > https://issues.apache.org/jira/browse/MESOS-2161 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/java/jni/org_apache_mesos_state_AbstractState.cpp > 1accc8a498a68b7cfd9e39dc1f3ce01c8bfd219f > src/java/src/org/apache/mesos/state/AbstractState.java > c66bf0519e7fc671d1e167ccd1e778dc65d3d8e6 > > Diff: https://reviews.apache.org/r/32152/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
